-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds logging for refunds #26274
Merged
Merged
Adds logging for refunds #26274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
might as well disable refunds for syndicate uplinks too |
Yuoko
pushed a commit
to ss14-ganimed/ENT14-Master
that referenced
this pull request
Mar 30, 2024
* Fix store refunds (space-wizards#26173) * Fix anomaly decay logs (space-wizards#26180) Fix anomaly decay logs (space-wizards#26122) * Small species melee weapon change (space-wizards#26183) * inital * Update animals.yml * Update engine to v214.2.0 (space-wizards#26190) * Recolor paper-stamp detective (space-wizards#26194) the old seal of the detective on paper has been changed to a new one * Change collision mask of canisters to allow passing through cargo flaps (space-wizards#26193) Co-authored-by: Jeff <velcroboy333@hotmail.com> * Fix presetidcard extended access throwing (space-wizards#26195) * Update Credits (space-wizards#26196) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * Add explosion-proof backpack to uplink (space-wizards#26187) * Backpacks * move to wearables * Update Resources/Prototypes/Catalog/uplink_catalog.yml * Update Resources/Prototypes/Entities/Clothing/Back/backpacks.yml --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Gives glue tag to crazy glue (space-wizards#26154) * SlowContactsSystem to SpeedModifierContactsSystem mini rework (space-wizards#26110) * rework * update logic * Add decoy syndicate bomb to uplink (space-wizards#26034) bombening * Obsolete `Logger` cleanup for `EntitySystem`s part 2 (space-wizards#26159) * Kill the static InRangeUnOccluded * Adjusted 4 more EntitySystems that were missed. * Update blood related tips! (space-wizards#25809) * Added 18 new bounties to cargo (space-wizards#26160) * Added 18 new bounties + tags, couple of balance tweaks * Oops, 2 corn tags. * Fixed another duplicate from merge conflict * Fixed all arbitrage issues * Removed metamorphic glass/manly dorf bounty * Removed manly dorf bounty * Removed manly dorf bounty * Removed manly dorf bounty * Changed hiviz tag, removed commented out bounty * Removed extra line * Change HiViz tag * Removed unused tag * Removed LaceupShoes, changed HiViz * Changed flavor text for fruit bounty * Removed live mouse bounty * Unify `Content`'s `EntitySystem` logging (space-wizards#26216) Use Log with generated sawmill name rather than explicitly named one for all non rule-based Content EntitySystems. * New wooden furniture (space-wizards#26182) * ю * Fences * bench, stairs and fence shadow * small gate desc * empty * empty * destructible * price fix * Fix barotrauma calculations The math for our pressure damage (barotrauma) system is directly taken from TG. The constants are the same and the math is almost the same. However there are two errors. 1. Pressure damage started being applied within the WARNING bounds, rather than the HAZARD bounds. This means you started taking low pressure damage at 50 kPa instead of the intended 20 kPa, and also the HUD icon didn't show "danger" like it should even if you were already taking damage. 2. The calculations for high pressure damage were wrong. These are supposed to be linearly scaled, but the function was wrong so the scaling didn't actually work properly (especially when considering the fixed bounds above). This appears to be the case because the function was taken from an incorrect comment in the original source, rather than the real math. Both of these issues are now fixed to match the TG behavior. Note that this somewhat nerfs pressure damage in non-extreme circumstances. e.g. a room at 40 kPa now gives NO pressure damage, whereas previously it would do full space damage. The description of the pressure alerts is wrong for "low" severity, but I can't be arsed to fix that right now. Alerts don't have a way to change the description depending on severity... * Increase air alarm low pressure thresholds. If a room's pressure drops it can become unbreathable long before people start taking pressure damage, and so also long before the air alarm starts reporting a danger state. I've increased the values so that the air alarm should show danger if the pressure becomes so low as to be unbreathable. * Make puddle smoothing better (space-wizards#26171) puddles * Change Syndie Monkey Price 8-6 TC (space-wizards#26214) Price 8-6 TC * Criminal Record Icons below Job Icons (space-wizards#26203) SS13 Criminal Record Icon Location REAL Adds a new Offset DataField to the StatusIcon Prototype. It effects status icon location on a per-pixel level. Not sure what else it could be used for, but hey, nothing wrong with generalizing. Also moves the mindshield icon priority to one, to fix an unreported bug with them covering non-job icons. * Fixed safe filling with WT550 (space-wizards#26208) * Suit slot weapon consistency + visuals (space-wizards#26152) suit slot my beloved Co-authored-by: vanx <#vanxxxx> * make romerol work on the dead (space-wizards#26222) * a * review * g * reach update (space-wizards#26224) * reach update * fixgridatmos * invalid link error * move arrivals to the side * who are we if we just get squashmerged anyway * chocolate machine * Move faction exception and everything it needs to shared (space-wizards#25154) * move faction prototype to shared * move faction exception and member stuff to shared * fix breaking changes for random stuff * move pettable friend stuff to shared * mostly fix * final fixy * dragonops * final fixy II * use querys and fix warpspeed fish (probably) * fixer * Rrrr! --------- Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> * Add reckless replay load button (space-wizards#26212) * Add reckless replay load button * A * More descriptive button * Fix borg charger error (space-wizards#26230) Fix borg chargers not working * Improves Medical Hud interface and functionality (space-wizards#26027) * Improvements to the medical hud interface * Adds an icon for SSD players * Indentation fix * Update sprites, changes direction and adds new status icon. * Adds decomposing icon * Code cleaning * Changes Crit Icon sprite * Simplifies the decision structure * Changes copyright line * Changes Critical Icon sprite * Makes the Critical Icon border darker * Changes sprites to /tg/ station * Updates copyright * Makes Dead Icon animation slight faster * Code cleaning * Remove some unused imports * Code cleaning and rename icon * Minor code cleaning * fix decoy bomb uplink category (space-wizards#26205) move * Increase lone ops TC from 40 to 60 (space-wizards#26130) * Create lone ops outfit and 60 TC radio * Changed lone op entity to use the new loneop outfit prototype * Fix shop --------- Co-authored-by: Plykiya <plykiya@protonmail.com> * Fix barotrauma pressure protection (space-wizards#26236) Oops In space-wizards#26217 I re-organized the logic for the calculation. Part of that was moving the logic for GetFeltLowPressure and GetFeltHighPressure to be done before we actually check the hazard thresholds. What I didn't realize is that, with how our pressure protection is set up, these functions can return values so extreme they rebound into the other category. For example, according to the math, when you're wearing a hardsuit in a low-pressure environment you have "felt" pressure of 1000 kPa. Yeah that's not right. Now these functions clamp their result to OneAtmosphere, in the appropriate direction (101.3 kPa). Fixes space-wizards#26234 * makes closets/lockers better (space-wizards#24942) * hmngm * fix * Manual changelog update * Spray Paint (Review Ready) (space-wizards#23003) * Spray Paint (Draft) * paint colors, paints in maints loot, cargo crate of paints. * fix * remove paint (sort of) * moved paintcleaner into own system * Moved paint to server (had to unfortunately) * doafter now breaks when moving away. * cant paint mobstatecomp * loads of fixes * fixes * fixes * nopaintshadercomp * fixes * fix * use locale for paint remove string * remove nopaintshadercomponent and use blacklist * remove enabled.true from visualizer * paint doafter event. * add verbs for paint and remove paint and icon for paint verb. * fixes * no longer replaces shader when shader exists. * replace forloop with foreach, check shader before adding and removing. * paint doafter now separate so no copy paste code * Entities in sprayed targets item slots are also now correctly sprayed. * fix * fix * fix airlock psray painter now removes painted before painting door. * spray paints now use openablecomponent. * fix * fix damn accesstypes. * fix * fix * Automatic changelog update * Include bans in adminremarks command (space-wizards#26240) Fixes space-wizards#20645 * Automatic changelog update * Updated the TEG page (space-wizards#26170) * Ported from guidebook-cleanup branch on my fork * Missed a skill issue, thanks Tayrtahn * Fixed misinformation * Automatic changelog update * Adds craftable ducky slippers (space-wizards#26138) * Craftable ducky slippers * fix node --------- Co-authored-by: Plykiya <plykiya@protonmail.com> * saltern paramedic slot (space-wizards#26038) add paramedic to prototype Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * Bumps LoneOps minimum required players to 20 (space-wizards#26244) done * Automatic changelog update * Zombies can very slowly regen heat and shock damage (space-wizards#25925) Update ZombieComponent.cs * Automatic changelog update * Initial Infected can see each other (space-wizards#25934) initial infected icon * Automatic changelog update * Fix SCRAM implant not working while cuffed. Incidentally fix freedom implant working while dead/crit (space-wizards#25978) * Fix SCRAM implant not being usable while in cuffs. Also fix freedom implant from working while dead/crit as a side effect * Move check up to apply to all actions and do thing I forgor to do before * Change check into an ActionBlocker check that also checks whether the user is sleeping. * Make checking for Consciousness the default for actions Went through and chose what I believe to be sensible defaults for actions that had CheckCanInteract. * Fix typos my beloved I had an unbelievable skill issue * Fix major skill issue * Automatic changelog update * Fix recycled containers deleting items inside them (space-wizards#26045) * Removes items from containers in reclaimers * Made it into an event instead * Sloth review comment * Fix indentation and rename field * Automatic changelog update * Fix artifact report info (space-wizards#26252) * Update ArtifactReports.xml Fix conflicting info * Small tweak to wording * Automatic changelog update * Pulling rework v2 (space-wizards#24936) * Pulling rework Fixing up the FOUR systems managing pulling, all the shitcode, and also making it nicer ingame. * More pulling cleanup * stats * More cleanup * First draft * More pulling * weh * Fix puller * Pulling working * Fix merge * Dunked * Self-merge time * Fix hotkey * Fix container changes * oop * Fix multi-pulling * Move alerts cleanup. * pulling fixes * Store Refund Fix (space-wizards#26251) Removes else that accidentally enables refunds * Automatic changelog update * Changed current value to unextracted value in artifact report guidebook (space-wizards#26253) * Fix name Forgot the name was also different * Fix Name, wording happened so fast I messed up * Simplify DoAfterArgs behavior for movement and distance checks (space-wizards#25226) * Merge BreakOnWeightlessMove and BreakOnMove. Provide different theshold for weightless movement. * Adjust WeightlessMovementThresholds. Put a thing I forgot to put in the doafterargs. * Make DoAfterArgs only use OnMove to determine whether to check for movement and MoveThreshold to determine the threshold regardless of weightlessness. Gave DistanceThreshold a default value which will always be checked now. * Fix issue introduced by merge. * Use interaction system for determining whether a distance is within range * Fix incorrect doafter args introduced by previous merge. Forgor to commit these. * Exorcise ghost. The execution system should have been deleted when I merged previously. For a reason I cannot comprehend it came back, but only the execution system. * Exorcise ghost Pt. 2 * Allow for movement check to be overriden in zero g and adjust doafter args where needed. You can now override checking for movement in zero g with the BreakOnWeightlessMove bool. By default it will check. The following doafters were made to ignore the movement check in zero g: - Healing yourself with healing items, - Removing embedded projectiles, - Using tools like welders and crowbars * Adjust distance for cuffing/uncuffing to work. Make injections not break on weightless movement. * Fix evil incorrect and uneeded comments * Fix build (space-wizards#26258) * Fix build - Fixes a couple paint things that were broken. * wat * Fix Fland's Cargo Shuttle Atmos (space-wizards#26273) * Adds logging for refunds (space-wizards#26274) LGTM * spawn panel rock crab suffix (space-wizards#26264) crab crab crab crab crab its all crabs. * Code cleanup: Dirty(Comp) (space-wizards#26238) * Replaced uses of Dirty(Component) with Dirty(Uid, Component) Modified some systems (notably pulling-related) to use uids. * Missed a few * Revert changes to pulling * No * new book - Tales of a Tired Janitor (space-wizards#24441) * book * Update book-authorbooks.ftl * make traitor syndicate reinforcements get the traitor role (space-wizards#25400) inital * Thrown soap/banana/(etc?) will fail to slip until it lands (space-wizards#24494) * throw miss * event * whoops Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * fix popup duplication * Separate cancellable event * no popup, no problem * remove leftover stuff --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Automatic changelog update * Monkey and gorilla melee weapon fix (space-wizards#26288) Update animals.yml * Fix blunt melee weapon hitsound (space-wizards#26286) * ok * Update welders.yml * Fix EFCore obsoletion warnings in Content.Server.Database (space-wizards#26285) * Fix wire layout inheritance. (space-wizards#26289) Wire layouts manually navigate the inheritance hierarchy, but the data fields on the prototypes were also automatically inherited already. This meant that inheriting a wire layout prototype and changing nothing would cause the wires to be duplicated unless they were manually modified on top. Fix is easy: just disable inheritance on the data fields. Also, integration test for it. * Per-department wire layouts (space-wizards#26247) * add per-department wire layouts * fix science/research inconsistency * fix wireLayout inheritance * science is no longer security * Security doors back to normal wire count * implement proper wire inheritance * revert WiresSystem.cs fix * Automatic changelog update * Pizza is not a fruit (space-wizards#26293) * Pizza is not a fruit * Also the slice * Let the lizards still eat pizza * Automatic changelog update * fix legally distinct visor man plush name. (space-wizards#26299) am in vr. approved by real spaniard. * Fix some invalid damage types (space-wizards#26295) Fixed some invalid damage types * Code cleanup: Purge calls to obsolete EntityCoordinates methods (space-wizards#26292) * Purge calls to obsolete EntityCoordinates methods * Pizza defruited; rerun those tests! * Rats eyes glow in dark + reorganize rat textures (space-wizards#26300) * Split mice from rats and made rats eye glow + added red eyes to regal rats (Both king and buff) + normal rats - removed mouse-3 sprites from mice and moved it into a dedicated rat rsi +fixed admin smite wording (you turn players into mice, not rats) * minor formatting fix * removed version numbers float. * Typo fix + removed unneeded layer name * Automatic changelog update * Improve admin message seen/dismiss state. (space-wizards#26223) Fixes space-wizards#26211 Admin messages now have separate "seen" and "dismissed" fields. The idea is that an admin should be able to tell whether a user pressed the "dismiss for now" button. Instead of using "seen" as "show this message to players when they join", "dismissed" is now used for this. Existing notes in the database will automatically be marked as dismissed on migration. A note cannot be dismissed without being seen (enforced via constraint in the database too, aren't I fancy). As part of this, it has become impossible for a player to play without dismissing the message in some form. Instead of a shitty popup window, the popup is now a fullscreen overlay that blocks clicks behind it, making the game unplayable. Also, if a user somehow has multiple messages they will be combined into one popup. Also I had enough respect for the codebase to make it look better and clean up the code somewhat. Yippee. * Automatic changelog update * Fix scram! implant keeping you pulled to someone when teleporting you (space-wizards#26309) * Fix scram! implant keeping you pulled to someone when teleporting you * Exorcise sleep deprivation speak * Automatic changelog update * Door Remote now shows Mode in UI (space-wizards#26162) * Prep for DoorRemote Status * Door Remote Mode Messages * plural opens and closes * never trust webedits --------- Co-authored-by: Plykiya <plykiya@protonmail.com> * remove rped (space-wizards#26316) * remove rped * trol --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Automatic changelog update * FTL UIScale fixes (space-wizards#26305) - Fix text drawing being offset. - Fix beacon snapping and distance check. - Fix DrawData being offset. - Fix bounds check for map objects not using PixelSize. * Automatic changelog update * Fix puller being improperly unset when pulling stops. (space-wizards#26312) Fix puller not being improperly unset on PullableComponent while being unpulled. When unpulled, the pullableComp has its puller field set to null after the message signifying the pulling has stopped has been sent. Since the component has a field to determine whether its owner is being pulled which is determined by the puller field, systems listening on the event would think that the owner of the component was still being pulled. * Automatic changelog update * bagel update (space-wizards#26326) * Sanitize "ig" (space-wizards#26328) replace ig * Snore is a trait now (space-wizards#26322) * Automatic changelog update * Code Cleanup: Purge obsolete MapManager methods (space-wizards#26279) * GetGrid * GridExists * TryGetGrid * Nerf budget insulated gloves (space-wizards#26318) Insul Chance * Automatic changelog update * Irish Coffee Recipe Tweak (space-wizards#26327) Update drinks.yml Why would this need to be 2+2=4 when 1+1=2 is the more logical reaction? * Automatic changelog update * Added verb action to Glue/Lube system (space-wizards#26002) * Added verb action to Glue/Lube system * Changes based on feedback * Fix TryGlue/Lube to use Entity<> rather than EntityUid, Component * Automatic changelog update * Fix missing semicolon after migration. (space-wizards#26337) Are you kidding me EFCore doesn't sanitize this itself? * The return of the 'long bedhead' haircut as an alternative (space-wizards#26336) * Automatic changelog update * Fix cross-grid spreader behavior (space-wizards#26346) * NPC steering tweaks (space-wizards#26351) - Fix the free node check considering the whole tile and not the poly. - Clear maps on direction resets. - More robust arrival checks for pathfinding nodes. * Automatic changelog update * Make air tanks appear on the back in suitstorage (space-wizards#26353) * g * a * jetpak * Fix crash on load when no slot key assigned (space-wizards#26354) Co-authored-by: wrexbe <wrexbe@protonmail.com> * Throwing Knives: Syndicate Kit (space-wizards#26026) * add * rename * change damage type and lower price * 6 tc * fix? * missed listing * Update Resources/Textures/Objects/Storage/boxes.rsi/meta.json * Update Resources/Textures/Objects/Storage/boxes.rsi/meta.json * Update Resources/Textures/Objects/Storage/boxes.rsi/meta.json --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Automatic changelog update * Changed black carpet texture to correctly align itself. (space-wizards#26358) * Partial atmos refactor (space-wizards#22521) * Reduce atmos component queries * Remove method events * Cache airtight data * Make MolesArchived nullable * Fix airtight cache * only get tile def once * Immutable mixtures * firelock queries * misc * misc cleanup * Trim disconnected tiles * Fix merge issues and bugs * Why does the PR keep increasing in scope * debug overlay * Fix bugs * Fix test, remove unused events * Add setmapatmos command * Fix overlays * Add map check * A * Resolve conflicts with space-wizards#26102 * Remove some obsolete methods * Automatic changelog update * 1x2 cable coils (space-wizards#26361) * 1x2 cable coils * sprite edits * Revert "sprite edits" This reverts commit 3c76c55. * coil rotate * Automatic changelog update * Fix bypassing vaulting clumsy check with verb action. (space-wizards#24977) * Fix bypassing bonking with verb * Revert "Fix bypassing bonking with verb" This reverts commit efa0f0f. * Properly refactored BonkSystem. * Oh hey, this is redundant now * Better solution * Reduced default bonk chance from 75% to 50% * Also do a little grammar fix * Moved BonkChance from BonkableComponent to ClumsyComponent. * Revert "Moved BonkChance from BonkableComponent to ClumsyComponent." This reverts commit 0acbd92. * Another little grammar fix * Matched default bonk doAfter length to default climb doAfter length * Fixed duplicate popups * Check CanVault with verb use too. Add granularity to ClimbingComponent and remove Leg/Foot requirement. * Don't show verb if you can't climb * Removed CanForceClimb * byref record struct * Automatic changelog update * Restrict door remotes to only being able to manipulate doors relevant to their type (space-wizards#26371) Restrict door remotes to only being able to manipulate doors relevant to their type. * Automatic changelog update * Update Credits (space-wizards#26373) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * Configuration argument for content packaging (space-wizards#25569) * Configuration argument for content packaging Needed this for something so here we are. I think someone mentioned they wanted this? Welp its here now * Add client, tiny fixes * Update submodule to 215.0.0 (space-wizards#26375) * Admin New Player Notification Sound (space-wizards#24327) play a sound to active admins when a new player joins * Fix playglobalsound autocompletion (space-wizards#26167) * Update submodule to 215.1.0 (space-wizards#26376) pitch * Haunted dungeon template (space-wizards#23768) * haunted dungeon * Initial work Still needs prefab gen work to make it interesting. * ime a worm * weh * Work * Slight tweaks --------- Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> * Maybe fix rsi truncheon error (space-wizards#26374) Co-authored-by: wrexbe <wrexbe@protonmail.com> * Add Prometheus stats for admin count (space-wizards#26284) * Add Prometheus stats for admin count Fixes space-wizards#20828 Reports time series for admin count. Counts are separated by state (active, AFK, or deadminned) and admin rank. * Use static constructor instead of static readonly for the metric Docs recommend this due to inconsistent execution of C# static constructors. * Remove static usage, use IoC IMeterFactory. --------- Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> * Hide empty marking categories in the markings picker (space-wizards#26377) Hide empty marking categories * Automatic changelog update * Give cap door remote his access (space-wizards#26378) Give cap doorremote his access * Automatic changelog update * Landmine stepoff (space-wizards#22962) * make landmine work on stepping off * update methods naming * made both step modes possible * updated stepoff event raise to not interfere with game physics internals * added comments * figuring out how audiosystem works * added beep sound effect, updated how stepoff trigger works to make it more consistent * updated source in attributions.yml * made stepoff working every time * introduced suggested changes * updated janitor's WetSignMine to have audio * made cleaner events and bashing my head at OnEndCollide event raise * inverted conditional where applicable * review --------- Co-authored-by: Yurii Kis <yurii.kis@smartteksas.com> Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> * Update submodule to 215.2.0 (space-wizards#26388) * Add stealthmins (space-wizards#26263) * Add stealthmin command. * Update Content.Server/Administration/Commands/AdminWhoCommand.cs As suggested by CE. Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com> * Add admin notifications for admins toggling stealthmin. * Localize stealthmin command --------- Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com> * Automatic changelog update * Run `fixgridatmos` for cargo & emergency shuttle (space-wizards#26382) Fix cargo & emergency shuttle * Automatic changelog update * Fix Medical Hud death icon animation and Changes critical icon (space-wizards#26391) Fix Dead Icon animation and changes Critical Icon * Automatic changelog update * Adds "untriaged" labeler workflow (space-wizards#26392) All new opened issues automatically get marked as "untriaged", so a maintainer can go through them properly. * Fixes store purchase events and adds support to raise a directed event (space-wizards#26389) * fixes store event check * raise directed product event * Store keybind priority (space-wizards#26356) * Fix saving keybind priority * Change movestoreditem keybind priority to prevent bug --------- Co-authored-by: wrexbe <wrexbe@protonmail.com> * Origin Station Update 12.03.2024 (space-wizards#26055) * Origin Station Update 12.03.2024 * implement PJB requested changes * changed ap magnum rounds for magnum rounds. * added west side maints door per pjb request. * removed laser glass box from captain quarters. * Make fland's mail into wheel-and-spoke distribution. (space-wizards#26404) * Remove CRLF, enforce with workflow (space-wizards#26401) * Check for CRLF in actions workflow Make emisse weep * Copy paste bottom text * I would like to thank StackOverflow for this spite PR. * Mention file name in message because the workflow tab doesn't display it. * dos2unix everything * Removed Cannabis from thief objectives (space-wizards#26412) * Removed Cannabis from thief objectives * Removed the steal group and from cannabis prototypes * Automatic changelog update * Gives borg industrial welder (space-wizards#26332) Update borg_modules.yml Changes basic welder in borg tool module to industrial welder * Automatic changelog update * Immovable Rod visual variations (space-wizards#25932) * Adds variations to immovable rod * slash oopsie * Changed prototypes from being hardcoded to being defined in the rules component * Changed from 10% chance to 5% * Changes based on feedback * Fix nullable error * Moved randomized logic to .yaml. Probabilities of alternate rods add up to 5%. * Fixed some icon rsi warnings (space-wizards#26414) Fixed some icon warnings Co-authored-by: wrexbe <wrexbe@protonmail.com> * Update close-master-pr.yml (space-wizards#26416) Fix name of "Close PRs on master" workflow * Accept cloth and ingots in the ammofab (space-wizards#26413) * Automatic changelog update * Fix admin verb to set unspawned ballisic ammo count (space-wizards#26411) Don't crash if an invalid value is given. * Use entity queries in ambient sound & power receiver systems (space-wizards#26410) * Unswap small and tall wodden fence gates (space-wizards#26409) * Holoprojectors crafted at lathes no longer come with a cell (space-wizards#26405) Adds versions of the holoprojectors (janitoral, fan, and field) that start without a battery and changes the lathe recipe to use these instead. This is consistant with flashlights, which when made do not start with a cell. Also it's a bit silly to have cargo printing a bunch of these to sell. * Automatic changelog update * Fix tags on antique laser gun (space-wizards#26398) It's missing the tag that's needed for it to go back in the glass storage box. * Automatic changelog update * Add astro-jungle/mowed grass and astro-snow (space-wizards#26381) * Automatic changelog update * Make parrots talk like parrots (space-wizards#26340) * Automatic changelog update * Create DeviceNetworkJammerComponent & System as a general way for entities to act as jammers (space-wizards#26342) * Add DeviceNetworkJammerComponent & System Allows for entities to "jam" DeviceNetwork packets. Whenever a device attempts to send a packet, the DeviceNetworkJammerSystem listens for the BeforePacketSentEvent. From there if any entity with the jammer component is within range of either the sender or receiver of the packet the event will be cancelled. Additionally jammers can only block packets in certain networks. If a packet is not being transmitted in one of the networks it can block then even if the jammer is in range the event will not be cancelled. The range is stored in the jammer component along with the networks it can jam. Jammable network ids are stored as strings which seems to be how custom networks are stored (E.g. network ids for suit sensors). To allow for all of this, the BeforePacketSentEvent was modified to provide the NetworkId. * Make JammerSystem for the radio jammer use the DeviceNetworkJammer. Remove redundant event. * Replace calls to TryDistance with InRange * nerf rad artifacts (space-wizards#26422) * Code cleanup: Purge obsoleted SharedPhysicsSystem methods (space-wizards#26287) Updated calls to SharedPhysicsSystem methods * Cleaner Grenade (space-wizards#25444) * Cleaner Grenade Added Cleaner Grenade * Sprite update Draw issue moment * Removed from jani closet | added box of cleanades * Automatic changelog update * Wearable Harmonicas (space-wizards#26261) * Wearable Instrument Base + Changed harmonica base Created the BaseWornInstrument base and updated the Harmonica to use it, being equipable in the neck slot. * Update instruments_wind.yml * compositions are cool and awesome * Automatic changelog update * Fix mailing units turning into disposal units while recharging. (space-wizards#26383) * Fix mailing units turning into disposal units while recharging. The states were hardcoded. * Fix error handling * Make default states constants * Automatic changelog update * Church Bells (space-wizards#26030) * Adds Church Bells * I'm dumb. * The bell is no longer haunted. * forgot attributions * change sounds so scary law no hunt * One day I'll stop needing to make an immediate micro-commit. One day. * God damn it. * Re-resprites labcoats (space-wizards#26425) * resprites labcoats again * fix tests * SS14-17313 Chatfactor: Chat Censorship Systems (space-wizards#25908) * SS14-17313 Chat Censorship Systems Adds some systems to manage chat censorship: 1. No-op: does nothing 2. SimpleCensor: a regex-free censor with a variety of rules to use 3. RegexCensor: a censor that uses regex. This exposes a singleton backed by a builder pattern (ChatCensor) that is set up, probably during the code init phase, and then globally available for your censorship needs. * Migrate to Shared * Add a reset function to the builder. * Resolve PJB's feedback; add unit tests * Make all implants unable to be implanted more than once (space-wizards#26250) * Make mind shield implants unable to be implanted more than once * Default AllowMultipleImplants to false and update implanters.yml * Use TryComp instead of TryGetComponent * Deny multiple implants for fun implants too. * Make comment more precise * Automatic changelog update * Nerf ninja research stealing (space-wizards#26421) * nerf ninja steal objective * fubar * Automatic changelog update * Reduces size of smaller cartons and fix size discrepancies with empty containers (space-wizards#26430) * Reduces size of smaller cartons * Fix trash bottles/cartons --------- Co-authored-by: Velcroboy <velcroboy333@hotmail.com> * Make chest rig purchasable in uplink (space-wizards#26427) a * Automatic changelog update * Fix atmos NaN error (space-wizards#26441) * Fix atmos NAN error * Remove redundant yaml entries * Automatic changelog update * Curtains fix (space-wizards#26447) * Update furniture.yml * Update curtains.yml * Update Resources/Prototypes/Entities/Structures/Decoration/curtains.yml Co-authored-by: Tayrtahn <tayrtahn@gmail.com> --------- Co-authored-by: Futuristic-OK <141568243+FuturisticRUS@users.noreply.github.com> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> * Update submodule (space-wizards#26451) * Update submodule (space-wizards#26454) * Minor cleanup of cuffablesystem (space-wizards#26434) * Fix cuffs breaking after they stop being pulled * Do proper interaction check for UncuffAttempt * Minor cleanup Take as much out as possible from _net.IsServer() if blocks. Misc cleanup * Automatic changelog update * Objects such as lighters/welders are now able to be dropped in disposal units. (space-wizards#26463) Don't always mark after interact event as handled for welder tools. Done with a view towards allowing disposal interaction post tool system handling. Co-authored-by: MQuatermain <misterquatermain@pm.me> * Update submodule to 216.0.0 (space-wizards#26467) * Revert "Give cap door remote his access" (space-wizards#26465) Revert "Give cap door remote his access (space-wizards#26378)" This reverts commit ea818ea. * Fix GhostRoleComponent performing randomization on ComponentInit (space-wizards#26466) * Fix ghostrole ComponentInit * A * a * Revert "Re-resprites labcoats (space-wizards#26425)" This reverts commit bd58954. * Remove Rubber Rounds, Give Security Disablers (space-wizards#26470) Remove Rubbers, give sec Disablers * Automatic changelog update * Removed Box of Hugs and Donk Pockets from Bounties (space-wizards#26481) As far as I know, the Box of Hugs only spawns on the clown and is used in the construction of a honkbot such that if the clown decided earlier to craft a honkbot or if the low price of some 3000 spesos is insufficient this bounty is impossible. Similarly, Donk Pockets are not a renewable resource and it has happened that a station has eaten too many for the bounty to be completed only to get it in rotation and esssentially lose a bounty slot forever. I would like it if each bounty was at least theoretically possible on any station it's likely to occur in, and there are too many where there aren't enough of these obtainable to complete the bounty, which is no fun. * Automatic changelog update * Artifact node IDs are now only 3 digits long (space-wizards#26482) * 2-digit nodes * 3-digits instead * Fix exclusive bounds * Automatic changelog update * Body code cleanup (space-wizards#24946) * Fix test * Kill float accumulators * Use entity proxy methods * DataField auto name generation where possible * Kill comp properties * Clean up server comps * Make events record structs * Clean up shared body code * Clean up server body code * Rename organ events to be same names as in med refactor * Add stacktrace to action error logs (space-wizards#26486) Add trace to action error logs * Late Join Menu Properly Retains Position On New Player Joins (space-wizards#26483) * When another player late joins it will correctly update the UI locally * Resolve passengers not displaying the correct message in late join * Improve final boolean comparison of button disabled state to be a bit neater * Automatic changelog update * Remove atmos method events (space-wizards#26402) * Remove HasAtmosphereMethodEvent * Remove GetTileMixturesMethodEvent * Remove GetTileMixtureMethodEvent * Remove GetAdjacentTilesMethodEvent * Add TileMixtureEnumerator * Remove GetAdjacentTileMixturesMethodEvent * Remove IsTileSpaceMethodEvent * Remove HotspotExposeMethodEvent * Remove pipe net method events * Remove device method events * Use Entity<T> * Misc fixes * A * Theres probably a few more of these * Fix other resolve errors * Misc ItemToggleSystem changes (space-wizards#26489) * Minor ItemToggleSystem tweaks * Update visuals on startup * Remove SetIgnited * Misc toggle fixes * Update ItemToggleHotComponent.cs * Allow cargo bounties to be sold off-station (space-wizards#26469) * Ported over code for delta-v to fix bounties * Added requested changes * Removed the station arg from "IsBountyComplete". It is unneeded and all calls just use a null value for it anyways * Automatic changelog update * Remove broadcast cooldown (space-wizards#26492) * Removed inconsistent broadcast cooldown whenever the "Announce" button is pressed on the communications terminal. * Revert "Removed inconsistent broadcast cooldown whenever the "Announce" button is pressed on the communications terminal." This reverts commit c730d64. * Reapply "Removed inconsistent broadcast cooldown whenever the "Announce" button is pressed on the communications terminal." This reverts commit 3c2d66a. * -Removed cooldown entirely * Add DoorBumpOpener to space dragon (space-wizards#26490) Add DoorBumpOpener to space dragon.yml * Automatic changelog update * Use nav beacon locations for announcements (space-wizards#26437) * use nav beacon locations for announcements * :thumbs_up: * Automatic changelog update * Arcade machine improvements (space-wizards#24200) * Give 'em something to talk about * Wire panel visuals * Wire graphics tweak * More ads and thanks * More ads for a noisy arcade * New screen for space villain machines * Implement EmitSoundIntervalComponent and a bunch of arcade noises * Require power for sounds * Allow earlier startup intervals * Orange glow * Audio attributions * Include the PR link * Replace EmitSoundInterval with expanded SpamEmitSound * Remove pacman-themed arcade sounds * Documentation good. * Updated methods to use Entity<T> * Refactored SpamEmitSound to get rid of accumulator and chance. * Fixed prewarm logic * Moved stuff to Shared * Fix outdated YAML * Better prediction, auto pause handling * Make enable/disable reset the timer instead of trying to save it. * Automatic changelog update * biggest gridinv update OF ALL TIME (space-wizards#25834) * add SaveItemLocation keybind * make item direction public to avoid having to change between Angle for no reason * add item location saving * show * Added a better save keybind, made it draw saved positions, and trying to save in a position it has already been saved in removes that position. * w * code style * Make taken spots appear blue * style * ! --------- Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: notquitehadouken <tripwiregamer@gmail.com> Co-authored-by: I.K <45953835+notquitehadouken@users.noreply.github.com> * dynamic alert sprites (space-wizards#25452) * dynamic alert sprite * fix fat cooldowns * Automatic changelog update * voicemask can select speech verb (space-wizards#25768) * add Name field to SpeechVerbPrototype * extra locale for voice mask ui * SpeechVerb ui and handling * raaaaaaaaa * reeeeeeeeal Co-authored-by: Tayrtahn <tayrtahn@gmail.com> * fix sort * did you hear john syndicate died of ligma * Update Content.Client/VoiceMask/VoiceMaskNameChangeWindow.xaml --------- Co-authored-by: deltanedas <@deltanedas:kde.org> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Automatic changelog update * Separate "thank you" messages from general ads (space-wizards#25867) * Separated "thank you" messages from general ads * Moved MessagePackPrototype to shared, cleaned up AdvertiseComponent, and actually killed AdvertisementsPackPrototype. +More suggests changes. * Rename PackPrototypeID to Pack in both components. * Фиксы * Fix master (space-wizards#26501) * Fix master * this * messages * Fix missing verb name parrot * Fix messagePack for blockgame and spacevillain --------- Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com> * Фикс * Фикс * Фикс лобби * очередной фикс апстрима * Фиксы юмлок * Фикс запуска сервера * Фикс клиента * фикс * Фикс подключения клиента к серверу * Фикс лобби * Некоторые переводы * Переводы и фикс РНД * Пул карт --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: LordCarve <27449516+LordCarve@users.noreply.github.com> Co-authored-by: Mr. 27 <45323883+Dutch-VanDerLinde@users.noreply.github.com> Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com> Co-authored-by: Awlod <159960340+Awlod@users.noreply.github.com> Co-authored-by: Velcroboy <107660393+IamVelcroboy@users.noreply.github.com> Co-authored-by: Jeff <velcroboy333@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> Co-authored-by: 21Melkuu <79728504+21Melkuu@users.noreply.github.com> Co-authored-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com> Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com> Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com> Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com> Co-authored-by: wafehling <wafehling@users.noreply.github.com> Co-authored-by: Ko4ergaPunk <62609550+Ko4ergaPunk@users.noreply.github.com> Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com> Co-authored-by: potato1234_x <79580518+potato1234x@users.noreply.github.com> Co-authored-by: FungiFellow <151778459+FungiFellow@users.noreply.github.com> Co-authored-by: Golinth <amh2023@gmail.com> Co-authored-by: Kevin Zheng <kevinz5000@gmail.com> Co-authored-by: HappyRoach <117393350+HappyRoach@users.noreply.github.com> Co-authored-by: vanx <61917534+Vaaankas@users.noreply.github.com> Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com> Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com> Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> Co-authored-by: Tayrtahn <tayrtahn@gmail.com> Co-authored-by: DoutorWhite <68350815+DoutorWhite@users.noreply.github.com> Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com> Co-authored-by: Plykiya <plykiya@protonmail.com> Co-authored-by: brainfood1183 <113240905+brainfood1183@users.noreply.github.com> Co-authored-by: Terraspark4941 <terraspark4941@gmail.com> Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com> Co-authored-by: shamp <140359015+shampunj@users.noreply.github.com> Co-authored-by: Killerqu00 <47712032+Killerqu00@users.noreply.github.com> Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com> Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com> Co-authored-by: Verm <32827189+Vermidia@users.noreply.github.com> Co-authored-by: keronshb <54602815+keronshb@users.noreply.github.com> Co-authored-by: Nairod <110078045+Nairodian@users.noreply.github.com> Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com> Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com> Co-authored-by: James Simonson <jamessimo89@gmail.com> Co-authored-by: Doctor-Cpu <77215380+Doctor-Cpu@users.noreply.github.com> Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com> Co-authored-by: liltenhead <104418166+liltenhead@users.noreply.github.com> Co-authored-by: BlitzTheSquishy <73762869+BlitzTheSquishy@users.noreply.github.com> Co-authored-by: RenQ <164364533+ImRenQ@users.noreply.github.com> Co-authored-by: Wrexbe (Josh) <81056464+wrexbe@users.noreply.github.com> Co-authored-by: wrexbe <wrexbe@protonmail.com> Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com> Co-authored-by: OnyxTheBrave <131422822+OnyxTheBrave@users.noreply.github.com> Co-authored-by: Vasilis <vasilis@pikachu.systems> Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com> Co-authored-by: Baptr0b0t <152836416+Baptr0b0t@users.noreply.github.com> Co-authored-by: KISS <59531932+YuriyKiss@users.noreply.github.com> Co-authored-by: Yurii Kis <yurii.kis@smartteksas.com> Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com> Co-authored-by: ChaseFlorom <57235581+ChaseFlorom@users.noreply.github.com> Co-authored-by: SoulFN <164462467+SoulFN@users.noreply.github.com> Co-authored-by: Luminight <balazscsabai98@gmail.com> Co-authored-by: Callmore <22885888+Callmore@users.noreply.github.com> Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com> Co-authored-by: DenisShvalov <115770678+DenisShvalov@users.noreply.github.com> Co-authored-by: Weax <59857479+ImWeax@users.noreply.github.com> Co-authored-by: Sphiral <145869023+SphiraI@users.noreply.github.com> Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com> Co-authored-by: Hannah Giovanna Dawson <karakkaraz@gmail.com> Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com> Co-authored-by: Futuristic-OK <141568243+Futuristic-OK@users.noreply.github.com> Co-authored-by: Futuristic-OK <141568243+FuturisticRUS@users.noreply.github.com> Co-authored-by: Jake Huxell <JakeHuxell@pm.me> Co-authored-by: MQuatermain <misterquatermain@pm.me> Co-authored-by: Ghagliiarghii <68826635+Ghagliiarghii@users.noreply.github.com> Co-authored-by: 0x6273 <0x40@keemail.me> Co-authored-by: blueDev2 <89804215+blueDev2@users.noreply.github.com> Co-authored-by: superjj18 <gagnonjake@gmail.com> Co-authored-by: notquitehadouken <tripwiregamer@gmail.com> Co-authored-by: I.K <45953835+notquitehadouken@users.noreply.github.com> Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
4 tasks
VMSolidus
added a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
May 29, 2024
## Mirror of PR #26274: [Adds logging for refunds](space-wizards/space-station-14#26274) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `85f4b43db1c0256e6d4c48a01558e8cc0a883ada` PR opened by <img src="https://avatars.githubusercontent.com/u/54602815?v=4" width="16"/><a href="https://github.com/keronshb"> keronshb</a> at 2024-03-19 23:42:22 UTC --- PR changed 2 files with 4 additions and 0 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > Refunds now have logging > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Good for admins to keep track of. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > A Store Refund entry was added into the logging enum and a log entry is made when a refund is successful. </details> Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Peptide90
pushed a commit
to SS14-Classic/deep-station-14
that referenced
this pull request
May 29, 2024
* Initial Port * Should fix test fail * Edge with Experimental Supermatter Engine * Update edge.yml * New edge by Colintel * Update edge.yml * Update edge.yml * Physics based air throws * Update base_structureclosets.yml * Updates for review * Hello, this is an asymptote. Divide by zero must be an exit condition. * Adding the clamp back in * better sound looping * I found another small optimization * Another one * guh * Psionic Refactor pt 1 * Last bit * Last one missed * I accidentally sent the DeltaV legacy version of these * Update edge.yml * New Cvar * Update comments for documentation * Apply suggestions from code review Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> * Update supermatter * Finishing Mind Swap rework * Noospheric Zap updating * Almost done * guh * More migrations * Final migrations * Last set of migrations * Update PsionicsSystem.cs * Almost got it, one last bug to squash * slightly more acccurate but still not quite right * Update PyrokinesisPowerSystem.cs * removing some errant instances of potentialpsionic * Revert "removing some errant instances of potentialpsionic" This reverts commit 0597405a48a588c9127e1bdbdca1b3d8aae81732. * Final power update * Update psionicPowers.yml * Update psionic.ftl * some more small tweaks * Update PotentialPsionicComponent.cs * Update Content.Server/Psionics/Abilities/PsionicAbilitiesSystem.cs Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> * Update PsionicAbilitiesSystem.cs * remove downstream comments * Giving pyrokinesis back to ifrit, and setting up base caster stat bonuses to roundstart casters * Update familiars.yml * MORE * Update AtmosphereSystem.HighPressureDelta.cs * guh, last push * Fix for objects getting stuck on walls, new CVar for more expensive airflow option. * Update animals.yml * Fix tiny mobs boiling themselves to death * 1984'ing GlobalRollforward (#423) GIVE ME BACK THE TESTS. * Listening Post Earlier Start (#409) # Description This was something that always annoyed me back when I made this for DeltaV. One key feature of the Listening Post was that it would have acted to encourage traitors to actually buy the encryption key bundle, since it had the possibility of letting them get radio support from a listening post. At the time Debug insisted it should only ever spawn extremely late in the around, giving it a sufficiently low weight that it would only appear usually an hour into the round. By this point all of the traitors had either been caught or had already done their thing, thus defeating the entire point of it. It also had an absurdly high minimum player count relative to the actual threat the outpost serves, ensuring that it would never appear on lowpop servers. Seriously not even stationwide lethal threats such as Xenos Ventcritters had as high of a minimum player count. # Changelog :cl: - tweak: Syndicate Listening Posts can now appear any time in a round, and can appear on low-pop servers. * Automatic Changelog Update (#409) * Mirror: Add Prometheus stats for admin count (#323) ## Mirror of PR #26284: [Add Prometheus stats for admin count](https://github.com/space-wizards/space-station-14/pull/26284) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `a1817a12dbb385275f4273c1abf48fac0a989ddd` PR opened by <img src="https://avatars.githubusercontent.com/u/8107459?v=4" width="16"/><a href="https://github.com/PJB3005"> PJB3005</a> at 2024-03-20 10:12:29 UTC --- PR changed 2 files with 106 additions and 1 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > Fixes #20828 > > Reports time series for admin count. Counts are separated by state (active, AFK, or deadminned) and admin rank. > > Requires engine master </details> Co-authored-by: SimpleStation14 <Unknown> * Walls/Windows Resprites! (#402) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Walls/Windows Resprites! <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Import the changes that i provided to frontier in PR: https://github.com/new-frontiers-14/frontier-station-14/pull/418 to EE, including part of this PR: https://github.com/new-frontiers-14/frontier-station-14/pull/757 Those Walls/Windows LOOK EXTREMLY MORE BETTER then the old TG walls/windows, Common its 2024! We need DRIP IN ALL WALLS! .yml changes are needed for connection to walls/window and prevent connected from doors, shutters, ect... --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Import Sprites. - [x] yml changes --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/Simple-Station/Einstein-Engines/assets/45297731/28221333-4c14-44d4-8557-697462d676f2) </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Better wall sprites. - tweak: Better window sprites. * Radio Resprites! (#404) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Radio Resprites! <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Radio Respsrites madness changes all the Headset sprites, Radio, Talkwalkies, Beacon and signaller. This also removed the "radio" sprite... well its replace it with the "old-radio". --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Sprite Import --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/Simple-Station/Einstein-Engines/assets/45297731/b90d8de8-4ac8-403d-bee4-348175544f59) </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Radio Resprites, Talkwalkies, Beacon, Headset... - tweak: Radio and uplink radio looks the same, make sure to check what freq the radio is on! * Automatic Changelog Update (#402) * Automatic Changelog Update (#404) * Mirror: Change Syndie Monkey Price 8-6 TC (#243) ## Mirror of PR #26214: [Change Syndie Monkey Price 8-6 TC](https://github.com/space-wizards/space-station-14/pull/26214) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `6095383ce491e9cb4836662f3bc56ee26eee29f6` PR opened by <img src="https://avatars.githubusercontent.com/u/151778459?v=4" width="16"/><a href="https://github.com/FungiFellow"> FungiFellow</a> at 2024-03-17 17:55:32 UTC --- PR changed 1 files with 2 additions and 2 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > I decreased the Price of Monkey reinforcements from 8 to 6, > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Monkies are awful in combat and anyone can take them out with 1-3 shoves and aren't worth 8TC 90% of the time unless the consience piloting it is robust. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > :cl: > - tweak: Changed Monkey Reinf Price to 6TC </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Updated the TEG page (#260) ## Mirror of PR #26170: [Updated the TEG page](https://github.com/space-wizards/space-station-14/pull/26170) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `353784bfaed731b8a803a3191e51c9afaf6e5bb4` PR opened by <img src="https://avatars.githubusercontent.com/u/85469138?v=4" width="16"/><a href="https://github.com/Terraspark4941"> Terraspark4941</a> at 2024-03-16 05:21:22 UTC --- PR changed 1 files with 166 additions and 13 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Updated the TEG page to have actual information/meta about setting up the TEG > Ported from guidebook-cleanup branch on my fork > [ This information has been certified by a TEG-setup expert ] > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > It made me angry reading the old page and not getting the information that I needed > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > :cl: > - tweak: The TEG page in the guidebook has been updated with proper information! > > </details> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Red Neck Gaiter (#214) ## Mirror of PR #25891: [Red Neck Gaiter](https://github.com/space-wizards/space-station-14/pull/25891) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `1938768ea69ad2f69758036816142a205552eb63` PR opened by <img src="https://avatars.githubusercontent.com/u/110078045?v=4" width="16"/><a href="https://github.com/Nairodian"> Nairodian</a> at 2024-03-06 22:32:25 UTC --- PR changed 8 files with 41 additions and 0 deletions. The PR had the following labels: - No C# - Changes: Sprites --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Real simple. Adds a (shameless) recolor of the existing neck gaiter in a red variant and adds two of it to the AutoDrobe > > ## Why / Balance > I felt like a proper red face mask style was missing to go with the new cowboy stuff. > > ## Media > ![image](https://github.com/space-wizards/space-station-14/assets/110078045/bae039ea-7b0c-4d14-8351-c58ea164ad5d) > - [X] I have added screenshots/videos to this PR showcasing its changes ingame. > > **Changelog** > :cl: > - add: Added a new red neck gaiter to the AutoDrobe. > </details> --------- Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Add PVS command permissions (#207) ## Mirror of PR #26124: [Add PVS command permissions](https://github.com/space-wizards/space-station-14/pull/26124) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `361092a40b110049b85187e935f4eb531f36a99f` PR opened by <img src="https://avatars.githubusercontent.com/u/60421075?v=4" width="16"/><a href="https://github.com/ElectroJr"> ElectroJr</a> at 2024-03-15 03:05:58 UTC --- PR changed 1 files with 1 additions and 0 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > Requires https://github.com/space-wizards/RobustToolbox/pull/4958 </details> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: fix admin verb to set unspawned ballisic ammo count (#375) ## Mirror of PR #26411: [fix admin verb to set unspawned ballisic ammo count](https://github.com/space-wizards/space-station-14/pull/26411) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `451890b85b49e17a0019d107db4a31a48cdd3518` PR opened by <img src="https://avatars.githubusercontent.com/u/107586145?v=4" width="16"/><a href="https://github.com/IProduceWidgets"> IProduceWidgets</a> at 2024-03-24 21:06:57 UTC --- PR changed 2 files with 15 additions and 3 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Fixed #26362 > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > I made the UpdateBallisticAppearance function public, I can't think of any reason that's a bad idea. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > :ADMIN: > - fix: setting ballistic ammo counts for a magazine should no longer be able to crash your game. </details> Co-authored-by: SimpleStation14 <Unknown> * Glorious Tools! (#407) <!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Glorious Tools! <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Add//Change a bunch of tools sprites that was in the tool category to make them fit better in general, Old TG... please update.exe Anywho here they are! --- # TODO <!-- A list of everything you have to do before this PR is "complete" You probably won't have to complete everything before merging but it's good to leave future references --> - [x] Import Sprites --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p> ![image](https://github.com/Simple-Station/Einstein-Engines/assets/45297731/233559ef-0367-4836-a258-d41e481cba4e) </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: New Tools Sprites! * Mirror: new book - Tales of a Tired Janitor (#278) ## Mirror of PR #24441: [new book - Tales of a Tired Janitor](https://github.com/space-wizards/space-station-14/pull/24441) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `0a6921d5ef90ebaaf1e054178f2889889eea661c` PR opened by <img src="https://avatars.githubusercontent.com/u/149967078?v=4" width="16"/><a href="https://github.com/Boaz1111"> Boaz1111</a> at 2024-01-23 09:28:08 UTC --- PR changed 2 files with 22 additions and 0 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > I added a new book, as requested by someone in the discord. This book is about the life of a janitor working aboard a (presumably NT) space station "14". They describe the things they have to deal with, the disrespect from others, the lack of good equipment. > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > More variety in books, especially books indirectly talking about life on a space station, and the jobs on said station. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > no cl </details> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Automatic Changelog Update (#407) * Add More Suggested VSCode Extensions (#414) Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> * Mirror: Obsolete `Logger` cleanup for `EntitySystem`s part 2 (#237) ## Mirror of PR #26159: [Obsolete `Logger` cleanup for `EntitySystem`s part 2](https://github.com/space-wizards/space-station-14/pull/26159) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `7d275a4b5e4188db424cc417c609dced3f9aca89` PR opened by <img src="https://avatars.githubusercontent.com/u/27449516?v=4" width="16"/><a href="https://github.com/LordCarve"> LordCarve</a> at 2024-03-15 20:15:41 UTC --- PR changed 14 files with 36 additions and 25 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Part 2 of 2, continuation of #25941 > Gets rid of the remaining obsolete `Logger` method calls from all `EntitySystem`s and uses the expected `Log` to get at the proper sawmill. > > In particular: > 1. Make the `ExamineSystemShared`'s `InRangeUnObstructed` non-`static` (so finally able to use instance-based `Log` rather than `Logger`) and inject dependency to all systems that were using it as `static`. > 2. Adjust 4 more `EntitySystem`s to use `Log` rather than `Logger` that were missed in the previous PR. > > Tested that the game runs and the affected systems direct logs to the correct sawmill. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Using Logger directly for logging is marked obsolete. Brings some order to logs (i.e. all `EntitySystem` logs start with a preceding `system.`). > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > I'm pretty sure `ExamineSystemShared`'s `InRangeUnObstructed` not being `static` is the intended way since it being `static` dodges the IoC entirely. It even has dirty hacks such as getting the occluder system inside to make it happen. I didn't fix any of that as it's beyond the scope of this PR, but it's another thing that needs improving. > > These are the changes to the log sawmills: > `ExamineSystemShared.cs`: BEFORE: `root` -> NEW: `system.examine` > `AtmosphereSystem.Monstermos.cs`: BEFORE: `root` -> NEW: `system.atmosphere` > `TypingIndicatorSystem.cs`: BEFORE: `root` -> NEW: `system.typing_indicator` > `PiratesRuleSystem.cs` BEFORE: `pirates` -> NEW: `system.pirates_rule` > `TabletopSystem.Session.cs` BEFORE: `root` -> NEW: `system.tabletop` > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > Some logs now fall under a different sawmill (more precise). Any software that analyzes logs and makes assumptions on which sawmill do these logs fall to will need to be adjusted. </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: CargoConsoleMenu localization (#127) ## Mirror of PR #25931: [CargoConsoleMenu localization](https://github.com/space-wizards/space-station-14/pull/25931) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `6e38b992cfc607e09178efc178b86f35152f0cde` PR opened by <img src="https://avatars.githubusercontent.com/u/87994977?v=4" width="16"/><a href="https://github.com/modern-nm"> modern-nm</a> at 2024-03-08 14:46:29 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/19864447?v=4" width="16"/><a href="https://github.com/web-flow"> web-flow</a> at 2024-03-09 06:56:40 UTC --- PR changed 20 files with 211 additions and 195 deletions. The PR had the following labels: - Changes: UI --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > This PR adds localization capability for CargoConsoleMenu (name of entity: ComputerCargoOrders) > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Please let me tell you a story of my vision. First i decided to make these changes on one of russian community servers. But taking into account future changes of .yml files by space-wizards community (they are regularly added to our space-station build), we will have to constantly edit xml files to remove duplicate categories — imagine someone added cargoproduct with category "Fun", when we have tons of items with category "Развлечения". > > To summarize: my PR makes possible to localize categories of "cargoproduct" and makes communities do less work when upstream comes > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > New code considers strings comparisons of prototype.Category (Content.Client/Cargo/UI/CargoConsoleMenu.xaml.cs) using Loc.GetString(...). And that's all. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Off course there are no visible changes on eng-localization > > ![Снимок_ножницы](https://github.com/space-wizards/space-station-14/assets/87994977/5cdbf5df-c4cc-42e6-861b-aa35a009e957) > > That's how these changes look like on our community build, using other .ftl file > > ![Снимок_ножницы2](https://github.com/space-wizards/space-station-14/assets/87994977/20023fc8-5cdf-4069-981b-edbfa98fa31d) > > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > > .yml > - every category of type "cargoProduct" was edited to "cargoproduct-category-name-{categoryName}" > > .ftl > - file "cargoproduct-categories.ftl" was added to english localization to localize categories of cargoProduct > > .cs > - CargoConsoleMenu.xaml.cs got tweaks which prevent issues with strings comparisons > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: MODERN <87994977+modern-nm@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Updates spawners with new content (#86) ## Mirror of PR #1032: [Updates spawners with new content](https://github.com/DeltaV-Station/Delta-v/pull/1032) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-28 21:03:53 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-28 21:28:31 UTC</aside> <sup> `5e397c6e7b2d2513f49948fbba1eb1d658fe4a9e` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Title. Updates box, device, hat, machinepart, and seed spawners. > Will do Items later. > > ## Why / Balance > Just catching up </details> --------- Co-authored-by: Velcroboy <107660393+IamVelcroboy@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com> * Update PsionicRegenerationPowerSystem.cs * Revert "Merge branch 'VMSolidus-Psionic-Power-Refactor'" This reverts commit 15fc457e8f1ffa3a05966566dff93dbe6994310a, reversing changes made to c62f777aee0c5e28df70953f77de950009e42c13. * Update PsionicRegenerationPowerSystem.cs * aaaaaaaaa * Update PsionicRegenerationPowerSystem.cs * fun pvs fixes * Mirror: Fixes store purchase events and adds support to raise a directed event (#364) ## Mirror of PR #26389: [Fixes store purchase events and adds support to raise a directed event](https://github.com/space-wizards/space-station-14/pull/26389) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `4dced51f0d8d008714a14675b48c8fa2b7fa0ace` PR opened by <img src="https://avatars.githubusercontent.com/u/54602815?v=4" width="16"/><a href="https://github.com/keronshb"> keronshb</a> at 2024-03-24 14:16:44 UTC --- PR changed 2 files with 8 additions and 3 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > When testing around some things with the magic PR I found that the purchase event wasn't being compared correctly. Also I added support to raise the purchase event directed at the buyer instead of just a broadcast event. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > The equals method will now check for purchase event type instead of comparing the references. To make this stronger we should talk about creating a base store purchase event class. > > For directing the event I added a bool to raise on user and we check if that's true. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Adds logging for refunds (#275) ## Mirror of PR #26274: [Adds logging for refunds](https://github.com/space-wizards/space-station-14/pull/26274) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `85f4b43db1c0256e6d4c48a01558e8cc0a883ada` PR opened by <img src="https://avatars.githubusercontent.com/u/54602815?v=4" width="16"/><a href="https://github.com/keronshb"> keronshb</a> at 2024-03-19 23:42:22 UTC --- PR changed 2 files with 4 additions and 0 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > Refunds now have logging > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Good for admins to keep track of. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > A Store Refund entry was added into the logging enum and a log entry is made when a refund is successful. </details> Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Fix artifact report guidebook info (#268) ## Mirror of PR #26252: [Fix artifact report guidebook info](https://github.com/space-wizards/space-station-14/pull/26252) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `e70928fad8c849ac0fd48da1415b6b134f9336a8` PR opened by <img src="https://avatars.githubusercontent.com/u/32827189?v=4" width="16"/><a href="https://github.com/Vermidia"> Vermidia</a> at 2024-03-19 03:17:41 UTC --- PR changed 1 files with 1 additions and 1 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > Fix conflicting info > > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > > The line about current value still treated extracting points from artifacts as destroying them, so I've changed it to clarify how it works better. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > Really confusing when part of the guide tells you to always extract and the other says to be careful since it'll get destroyed. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > :cl: > - tweak: Made the Artifact Reports page up to date with current Xenoarchaeology > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > --> > </details> Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: More good looking inventory part 2.2 (instruments version) (#189) ## Mirror of PR #26090: [More good looking inventory part 2.2 (instruments version)](https://github.com/space-wizards/space-station-14/pull/26090) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `91aa6445714d6b833474fcb911c4c8555a54f799` PR opened by <img src="https://avatars.githubusercontent.com/u/124214523?v=4" width="16"/><a href="https://github.com/lzk228"> lzk228</a> at 2024-03-13 18:52:29 UTC --- PR changed 4 files with 12 additions and 4 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > - media > - fix tophat name > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > ![Screenshot_20240313_194028](https://github.com/space-wizards/space-station-14/assets/124214523/51640a13-f4b7-490d-8982-6d2e07dcc009) > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > no cl no fun > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Syringes that spawn with content start in inject mode (#129) ## Mirror of PR #25881: [Syringes that spawn with content start in inject mode](https://github.com/space-wizards/space-station-14/pull/25881) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `5cb48c922fa7236d07b463f0c38ada2d5805e54b` PR opened by <img src="https://avatars.githubusercontent.com/u/58439124?v=4" width="16"/><a href="https://github.com/Plykiya"> Plykiya</a> at 2024-03-06 13:43:59 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/19864447?v=4" width="16"/><a href="https://github.com/web-flow"> web-flow</a> at 2024-03-09 10:19:03 UTC --- PR changed 3 files with 25 additions and 23 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Made it so that syringes that spawn with content start out in inject mode rather than draw mode. Also got rid of unnecessary DataField names if they matched. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Grab bic syringe from medkit, use it on patient, it's in draw mode by default, cry. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > I added a new yml entity for prefilled syringes that starts in inject mode. > > I attempted to do it the "smart way" by changing the ComponentInit code to check for the solution amount and toggle based on that, but for some reason the solution was returning false on the server-side but not on the client-side so there was a desync in the Inject state. Couldn't really figure out how to fix it, so I just went with the dumb simple method instead. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > None > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > :cl: > - tweak: Pre-filled syringes start in inject mode now. </details> Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Fix vox custom sprites (#186) ## Mirror of PR #25989: [Fix vox custom sprites](https://github.com/space-wizards/space-station-14/pull/25989) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `8a77722f91a94846f0027f56b8d8f2ec76254d81` PR opened by <img src="https://avatars.githubusercontent.com/u/35878406?v=4" width="16"/><a href="https://github.com/Errant-4"> Errant-4</a> at 2024-03-11 09:29:16 UTC --- PR changed 1 files with 2 additions and 0 deletions. The PR had the following labels: - No C# - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Clothing with custom sprites for vox have been displaying the default sprites due to a component accident. > > ## Media > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > **Changelog** > :cl: Errant > - fix: Clothes with alternate sprites for vox once again show the alternate sprites, instead of the defaults. > </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Code cleanup: Purge calls to obsolete EntityCoordinates methods (#289) ## Mirror of PR #26292: [Code cleanup: Purge calls to obsolete EntityCoordinates methods](https://github.com/space-wizards/space-station-14/pull/26292) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `f4cb02fb0ca385c858569c07c51afb0d24ade949` PR opened by <img src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 16:04:43 UTC --- PR changed 34 files with 70 additions and 56 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Cleaned up some outdated code. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Clean code is happy code. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Updated all calls to obsolete EntityCoordinates methods (ToMap, ToMapPos, FromMap, ToVector2i, InRange) to non-obsolete ones (by passing in SharedTransformSystem as an arg). > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Code > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Snore is a trait now (#299) ## Mirror of PR #26322: [Snore is a trait now](https://github.com/space-wizards/space-station-14/pull/26322) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `3b3b874dd9222770da616ba07277842d6b7a09be` PR opened by <img src="https://avatars.githubusercontent.com/u/124214523?v=4" width="16"/><a href="https://github.com/lzk228"> lzk228</a> at 2024-03-21 23:18:00 UTC --- PR changed 4 files with 24 additions and 1 deletions. The PR had the following labels: --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Title. > Snore sound is emitting with trait. Without trait not. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Someone told me that snoring is a disease, and not every should have it so i decided to do this pr. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - tweak: Snoring is now a trait in character preference menu. > > </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Sanitize "ig" (#298) ## Mirror of PR #26328: [Sanitize "ig"](https://github.com/space-wizards/space-station-14/pull/26328) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `4f816b4b2f74db8da32cd157110df538e50eed1a` PR opened by <img src="https://avatars.githubusercontent.com/u/77215380?v=4" width="16"/><a href="https://github.com/Doctor-Cpu"> Doctor-Cpu</a> at 2024-03-22 05:20:30 UTC --- PR changed 2 files with 7 additions and 3 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > "ig" gets replaced with "i guess" > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Common slang online which I've seen being attempted to be used before. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > N/A > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > N/A > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > :cl: > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > Don't feel like one is needed. </details> Co-authored-by: SimpleStation14 <Unknown> * Mirror: Fix placement mode on chairs (#183) ## Mirror of PR #26041: [Fix placement mode on chairs](https://github.com/space-wizards/space-station-14/pull/26041) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `bcc147634af1fea7b5f53f18d136f44ed46cb053` PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-12 14:45:33 UTC --- PR changed 1 files with 8 additions and 7 deletions. The PR had the following labels: - No C# --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > Placement mode on chairs was donked up a little bit recently. This returns the ability to free place certain(unanchored) chairs while mapping. > > ## Why / Balance > More dynamic mapping > > ## Technical details > n/a > > ## Media > - [x] I have added screenshots/videos to this PR showcasing its changes in-game, **or** this PR does not require an in-game showcase > > ## Breaking changes > n/a > > **Changelog** > n/a </details> Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Fix mice steering (#134) ## Mirror of PR #25965: [Fix mice steering](https://github.com/space-wizards/space-station-14/pull/25965) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `819ec6361d0d2792b43357a6c45f8c95cb08d9ed` PR opened by <img src="https://avatars.githubusercontent.com/u/31366439?v=4" width="16"/><a href="https://github.com/metalgearsloth"> metalgearsloth</a> at 2024-03-10 14:57:30 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/19864447?v=4" width="16"/><a href="https://github.com/web-flow"> web-flow</a> at 2024-03-10 15:41:42 UTC --- PR changed 1 files with 24 additions and 1 deletions. The PR had the following labels: --- <details open="true"><summary><h1>Original Body</h1></summary> > Thinks there's obstacles when there isn't. Blending exposed it but it was an issue before. > > > :cl: > - fix: Fix NPC mouse movement. > </details> Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> Co-authored-by: VMSolidus <evilexecutive@gmail.com> * Mirror: Create DeviceNetworkJammerComponent & System as a general way for entities to act as jammers (#382) ## Mirror of PR #26342: [Create DeviceNetworkJammerComponent & System as a general way for entities to act as jammers](https://github.com/space-wizards/space-station-14/pull/26342) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `266cc85f57c883b3a604a66da91d94bb1e18ec5d` PR opened by <img src="https://avatars.githubusercontent.com/u/32041239?v=4" width="16"/><a href="https://github.com/nikthechampiongr"> nikthechampiongr</a> at 2024-03-22 19:17:23 UTC --- PR changed 7 files with 91 additions and 25 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > This PR creates the DeviceNetworkJammerComponent & System as a general way for entities to act as jammers for the DeviceNetwork. > > Additionally it adjusts the JammerSystem for the radio jammer to use this, and rips out the previous special code for jamming suit sensors. > > As a result of this, the radio jammer can now additionally jam the suit sensor server itself from receiving DeviceNetwork packets. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > This pr was requested by a maintainer. > > Additionally a general jamming system can have some utility in the future. E.g. an artifact effect. > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > > Whenever a device attempts to send a packet, the > DeviceNetworkJammerSystem listens for the BeforePacketSentEvent. > From there if any entity with the jammer component is within range of > either the sender or receiver of the packet the event will be cancelled. > Additionally jammers can only block packets in certain networks. If a > packet is not being transmitted in one of the networks it can block then > even if the jammer is in range the event will not be cancelled. > > The range is stored in the jammer c…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Refunds now have logging
Why / Balance
Good for admins to keep track of.
Technical details
A Store Refund entry was added into the logging enum and a log entry is made when a refund is successful.